src/client/hud/layers/EventsDisplay.ts (1)

37-42: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Fragile string parsing with magic offsets.

parseInboundNuke reverse-engineers the player name from hardcoded lengths (-20, -24, 7, -22) of the exact English message. If any of these strings change (or the message is localized), the slice silently returns the wrong name or null, and grouping quietly stops working. The MIRV offsets are especially error-prone because each ⚠️ is 2 UTF-16 units.

Cleaner option: pass the nuke type and player name as structured fields on the incoming event so no string parsing is needed. If parsing must stay, at least compute offsets from the suffix constants instead of literals:

♻️ Derive offsets from the suffix strings

 function parseInboundNuke(m: string): { player: string; nukeType: string } | null {
-  if (m.endsWith(" - atom bomb inbound")) return { player: m.slice(0, -20), nukeType: "atom" };
-  if (m.endsWith(" - hydrogen bomb inbound")) return { player: m.slice(0, -24), nukeType: "hydrogen" };
-  if (m.startsWith("⚠️⚠️⚠️ ") && m.endsWith(" - MIRV INBOUND ⚠️⚠️⚠️")) return { player: m.slice(7, -22), nukeType: "mirv" };
+  const atom = " - atom bomb inbound";
+  const hydrogen = " - hydrogen bomb inbound";
+  const mirvPre = "⚠️⚠️⚠️ ";
+  const mirvSuf = " - MIRV INBOUND ⚠️⚠️⚠️";
+  if (m.endsWith(atom)) return { player: m.slice(0, -atom.length), nukeType: "atom" };
+  if (m.endsWith(hydrogen)) return { player: m.slice(0, -hydrogen.length), nukeType: "hydrogen" };
+  if (m.startsWith(mirvPre) && m.endsWith(mirvSuf)) return { player: m.slice(mirvPre.length, -mirvSuf.length), nukeType: "mirv" };
   return null;
 }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/client/hud/layers/EventsDisplay.ts` around lines 37 - 42, The
parseInboundNuke helper is relying on fragile hardcoded slice offsets to recover
the player name from event text. Update EventsDisplay.parseInboundNuke to avoid
magic numbers by either passing structured player/nuke fields into the event
handling path, or by deriving the start/end offsets from the exact suffix
strings used in each message pattern. Keep the existing function and its MIRV
branch, but make the parsing length-safe so changes to the message text or
Unicode characters do not break grouping.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes